xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix compiler warning in xfs_trace.h

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix compiler warning in xfs_trace.h
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 28 Apr 2011 12:20:36 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110424190258.GA32137@xxxxxxxxxxxxx>
References: <20110424190258.GA32137@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sun, Apr 24, 2011 at 03:02:58PM -0400, Christoph Hellwig wrote:
> xfs_fsblock_t may be a 32-bit type on if XFS_BIG_BLKNOS is not set,
> make sure to cast a value of this type to an unsigned long long
> before using the ll printk qualifier.
> 
> Reported-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
> 
> Index: xfs/fs/xfs/linux-2.6/xfs_trace.h
> ===================================================================
> --- xfs.orig/fs/xfs/linux-2.6/xfs_trace.h     2011-04-22 06:22:11.409709360 
> +0200
> +++ xfs/fs/xfs/linux-2.6/xfs_trace.h  2011-04-22 06:22:30.756271218 +0200
> @@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
>                 __entry->wasfromfl,
>                 __entry->isfl,
>                 __entry->userdata,
> -               __entry->firstblock)
> +               (unsigned long long)__entry->firstblock)
>  )
>  
>  #define DEFINE_ALLOC_EVENT(name) \

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>