xfs
[Top] [All Lists]

Re: [PATCH] xfs: Remove duplicate XFS from xfs_alert_tag, neatening

To: aelder@xxxxxxx
Subject: Re: [PATCH] xfs: Remove duplicate XFS from xfs_alert_tag, neatening
From: Joe Perches <joe@xxxxxxxxxxx>
Date: Tue, 26 Apr 2011 13:54:08 -0700
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1303850805.2080.164.camel@doink>
References: <59d707d5d1bc37ef3a08fdd23c8e1fe72fa55fbb.1303419931.git.joe@xxxxxxxxxxx> <1303850805.2080.164.camel@doink>
On Tue, 2011-04-26 at 15:46 -0500, Alex Elder wrote:
> On Thu, 2011-04-21 at 14:08 -0700, Joe Perches wrote:
> > The xfs_printk in xfs_alert_tag doesn't need an XFS: prefix
> > as it's added by xfs_printk.
> > Add format checking to the non-debug inline function xfs_debug.
> > Miscellaneous function prototype argument alignment.
[]
> I'll highlight the fact that this was the last caller of
> xfs_printk().  As such I think it should just be eliminated,
> and make the use of xfs_info() or xfs_debug() mandatory.
> They are clean, easy, and have meaningful enough names
> that this should be fine.  (What do others think?)

I only wanted to point out the unnecessary "XFS:" duplication.
Taking out xfs_printk would save some text & data.
Do what you think appropriate.


<Prev in Thread] Current Thread [Next in Thread>