xfs
[Top] [All Lists]

Re: xfs build warning

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: xfs build warning
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 22 Apr 2011 00:14:30 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, Randy Dunlap <randy.dunlap@xxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1303416490.2581.518.camel@doink>
References: <4DA876C2.8050606@xxxxxxxxxx> <20110415173902.GA27378@xxxxxxxxxxxxx> <1303416490.2581.518.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Apr 21, 2011 at 03:08:10PM -0500, Alex Elder wrote:
> On Fri, 2011-04-15 at 13:39 -0400, Christoph Hellwig wrote:
> > On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
> > > on i386, when CONFIG_LBDAF is not enabled:
> > > 
> > > fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 
> > > 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
> > 
> > This should fix it:
> 
> Looks good.  Christoph, can I assume your signoff?
> 
> I wonder whether we'll ever need to cast the other
> fields that are based on abstractions from __uint32_t
> (like xfs_agblock_t, xfs_extlen_t, ...).

I'll resend it with a proper changelog and signoff.

<Prev in Thread] Current Thread [Next in Thread>