xfs
[Top] [All Lists]

[Fwd: Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips in

To: xfs@xxxxxxxxxxx
Subject: [Fwd: Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips in xfs_alloc_clear_busy]
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 21 Apr 2011 15:09:19 -0500
Reply-to: aelder@xxxxxxx
Forgot to reply-all.  Sorry.    -Alex

-------- Forwarded Message --------
From: Alex Elder <aelder@xxxxxxx>
Reply-to: aelder@xxxxxxx
To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips
in xfs_alloc_clear_busy
Date: Thu, 21 Apr 2011 15:08:32 -0500

On Mon, 2011-04-18 at 02:59 -0400, Christoph Hellwig wrote:
> Instead of finding the per-ag and then taking and releasing the pagb_lock
> for every single busy extent completed sort the list of busy extents and
> only switch betweens AGs where nessecary.  This becomes especially important
> with the online discard support which will hit this lock more often.

Looks good.

My only comment was going to be:
    Is it better to sort before when committed, or sort at
    insertion time?
But I worked through it and concluded you are doing exactly
the right thing.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>
  • [Fwd: Re: [PATCH 4/4] xfs: reduce the number of pagb_lock roundtrips in xfs_alloc_clear_busy], Alex Elder <=