xfs
[Top] [All Lists]

Re: xfs build warning

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: xfs build warning
From: Randy Dunlap <randy.dunlap@xxxxxxxxxx>
Date: Fri, 15 Apr 2011 10:47:47 -0700
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110415173902.GA27378@xxxxxxxxxxxxx>
Organization: Oracle Linux Engineering
References: <4DA876C2.8050606@xxxxxxxxxx> <20110415173902.GA27378@xxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0
On 04/15/11 10:39, Christoph Hellwig wrote:
> On Fri, Apr 15, 2011 at 09:48:02AM -0700, Randy Dunlap wrote:
>> on i386, when CONFIG_LBDAF is not enabled:
>>
>> fs/xfs/linux-2.6/./xfs_trace.h:1354: warning: format '%llx' expects type 
>> 'long long unsigned int', but argument 22 has type 'xfs_fsblock_t'
> 
> This should fix it:
> 
> Index: linux-2.6/fs/xfs/linux-2.6/xfs_trace.h
> ===================================================================
> --- linux-2.6.orig/fs/xfs/linux-2.6/xfs_trace.h       2011-04-15 
> 19:29:11.569340965 +0200
> +++ linux-2.6/fs/xfs/linux-2.6/xfs_trace.h    2011-04-15 19:30:09.679026159 
> +0200
> @@ -1418,7 +1418,7 @@ DECLARE_EVENT_CLASS(xfs_alloc_class,
>                 __entry->wasfromfl,
>                 __entry->isfl,
>                 __entry->userdata,
> -               __entry->firstblock)
> +               (unsigned long long)__entry->firstblock)
>  )
>  
>  #define DEFINE_ALLOC_EVENT(name) \

Acked-by: Randy Dunlap <randy.dunlap@xxxxxxxxxx>

Thanks.

-- 
~Randy

<Prev in Thread] Current Thread [Next in Thread>