xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix duplicate message output

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix duplicate message output
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 15 Apr 2011 03:46:40 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110412160651.GA22506@xxxxxxxxxxxxx>
References: <1302615260-29450-1-git-send-email-david@xxxxxxxxxxxxx> <20110412160651.GA22506@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Tue, Apr 12, 2011 at 12:06:51PM -0400, Christoph Hellwig wrote:
> On Tue, Apr 12, 2011 at 11:34:20PM +1000, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@xxxxxxxxxx>
> > 
> > Commit 957935dc ("xfs: fix xfs_debug warnings" broke the logic in
> > __xfs_printk(). Instead of only printing one of two possible output
> > strings based on whether the fs has a name or not, it outputs both.
> > Fix it to only output one message again.
> 
> My fault, sorry.
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

And since I recently upgraded my compiler this bug even causes 085
to oops the kernel for me, so pushing it ASAP would be good.

<Prev in Thread] Current Thread [Next in Thread>