Re: [PATCH, v2] xfs: cleanup duplicate initializations

[Alex Elder <aelder@xxxxxxx>]

On Thu, 2011-04-14 at 08:53 +1000, Dave Chinner wrote:
> On Wed, Apr 13, 2011 at 05:03:28PM -0500, Alex Elder wrote:
. . .
> > David, perhaps you could sign off on this version.
> > Meanwhile, another reviewer might make sense.
> 
> Seeing as you only added a hunk, I'd say that keeping his old
> sіgnoff is just fine.

OK.

> > 
> >                                     -Alex
> > 
> > follow these guidelines:
> > - leave initialization in the declaration block if it fits the line
> > - move to the code where it's more suitable ('for' init block)
> > 
> > Originally proposed by David Sterba <dsterba@xxxxxxx>
> 
> That is what the "From:" tag is for when you post someone else's
> patch. ;)

Good to know.  Thanks a lot for the review.

> Anyway, looks good now.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Cheers,
> 
> Dave.