xfs
[Top] [All Lists]

Re: [PATCH, v2] xfs: cleanup duplicate initializations

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH, v2] xfs: cleanup duplicate initializations
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 14 Apr 2011 09:50:39 -0500
Cc: David Sterba <dsterba@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110413225327.GM31057@dastard>
References: <1301332373-24914-1-git-send-email-dsterba@xxxxxxx> <1301338370.2622.10.camel@doink> <1302732208.2023.146.camel@doink> <20110413225327.GM31057@dastard>
Reply-to: aelder@xxxxxxx
On Thu, 2011-04-14 at 08:53 +1000, Dave Chinner wrote:
> On Wed, Apr 13, 2011 at 05:03:28PM -0500, Alex Elder wrote:
. . .
> > David, perhaps you could sign off on this version.
> > Meanwhile, another reviewer might make sense.
> 
> Seeing as you only added a hunk, I'd say that keeping his old
> sіgnoff is just fine.

OK.

> > 
> >                                     -Alex
> > 
> > follow these guidelines:
> > - leave initialization in the declaration block if it fits the line
> > - move to the code where it's more suitable ('for' init block)
> > 
> > Originally proposed by David Sterba <dsterba@xxxxxxx>
> 
> That is what the "From:" tag is for when you post someone else's
> patch. ;)

Good to know.  Thanks a lot for the review.

> Anyway, looks good now.
> 
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Cheers,
> 
> Dave.



<Prev in Thread] Current Thread [Next in Thread>