xfs
[Top] [All Lists]

Re: [PATCH, v2] xfs: cleanup duplicate initializations

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH, v2] xfs: cleanup duplicate initializations
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 14 Apr 2011 08:53:27 +1000
Cc: David Sterba <dsterba@xxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1302732208.2023.146.camel@doink>
References: <1301332373-24914-1-git-send-email-dsterba@xxxxxxx> <1301338370.2622.10.camel@doink> <1302732208.2023.146.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Apr 13, 2011 at 05:03:28PM -0500, Alex Elder wrote:
> On Mon, 2011-03-28 at 13:52 -0500, Alex Elder wrote:
> > On Mon, 2011-03-28 at 19:12 +0200, David Sterba wrote:
> > > follow these guidelines:
> > > - leave initialization in the declaration block if it fits the line
> > > - move to the code where it's more suitable ('for' init block)
> > > 
> > > Signed-off-by: David Sterba <dsterba@xxxxxxx>
> > 
> > Looks good.
> > 
> > Reviewed-by: Alex Elder <aelder@xxxxxxx>
> 
> I retract this.  The last chunk in the patch is erroneous.
> 
> Below is the original proposed patch, except I have
> modified the last chunk to be a correct fix for what
> appears to be a duplicate initialization.  (It was not,
> really, but I've changed it so only one assignment is
> made, and the result makes it more obvious what's
> going on.)
> 
> David, perhaps you could sign off on this version.
> Meanwhile, another reviewer might make sense.

Seeing as you only added a hunk, I'd say that keeping his old
sіgnoff is just fine.

> 
>                                       -Alex
> 
> follow these guidelines:
> - leave initialization in the declaration block if it fits the line
> - move to the code where it's more suitable ('for' init block)
> 
> Originally proposed by David Sterba <dsterba@xxxxxxx>

That is what the "From:" tag is for when you post someone else's
patch. ;)

Anyway, looks good now.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>