[Top] [All Lists]

Re: [PATCH] xfs: fix bmbt block allocation failures

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix bmbt block allocation failures
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Tue, 12 Apr 2011 09:56:27 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110411234158.GB29358@xxxxxxxxxxxxx>
References: <1302489251-1512-1-git-send-email-david@xxxxxxxxxxxxx> <20110411234158.GB29358@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Mon, Apr 11, 2011 at 07:41:58PM -0400, Christoph Hellwig wrote:
> On Mon, Apr 11, 2011 at 12:34:11PM +1000, Dave Chinner wrote:
> > http://oss.sgi.com/archives/xfs/2010-09/msg00438.html).  Firstly,
> > the missing args->total was causing the initial block to be
> > allocated from the freespace reserve. Secondly that the NEAR_BNO
> > allocation should probably be a START_BNO allocation to allow blocks
> > to be taken from a higher numbered AG.
> Looking over the use of ->total, isn't the ialloc btree code also
> incorrect by setting ->total to 0?

It probably is - I hadn't got that far yet. I wanted to get this
tested and reviewed so test 250 would no longer assert fail
everyone's debug build....

> The actual change looks good to me,
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>



Dave Chinner

<Prev in Thread] Current Thread [Next in Thread>