xfs
[Top] [All Lists]

Re: [xfs-masters] [PATCH] xfs_destroy_workqueues() should not be tagged

To: "Luck, Tony" <tony.luck@xxxxxxxxx>
Subject: Re: [xfs-masters] [PATCH] xfs_destroy_workqueues() should not be tagged with __exit
From: Christoph Hellwig <hch@xxxxxx>
Date: Mon, 11 Apr 2011 21:49:38 +0200
Cc: xfs-masters@xxxxxxxxxxx, dchinner@xxxxxxxxxx, xfs@xxxxxxxxxxx
In-reply-to: <4da3512411659d3276@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
References: <4da3512411659d3276@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.17 (2007-11-01)
On Mon, Apr 11, 2011 at 12:06:12PM -0700, Luck, Tony wrote:
> ia64 throws away .exit sections for the built-in CONFIG case, so routines
> that are used in other circumstances should not be tagged as __exit.
> 
> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>

Looks good,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> 
> ---
> 
> Should be applied after (or merged into) Dave Chinner's patch
>       xfs: convert the xfsaild threads to a workqueue
> which appeared as commit 0bf6a5bd4b55b466964ead6fa566d8f346a828ee in
> next-20110411
> 
> diff --git a/fs/xfs/linux-2.6/xfs_super.c b/fs/xfs/linux-2.6/xfs_super.c
> index 67d5b2c..b38e58d 100644
> --- a/fs/xfs/linux-2.6/xfs_super.c
> +++ b/fs/xfs/linux-2.6/xfs_super.c
> @@ -1741,7 +1741,7 @@ out:
>       return -ENOMEM;
>  }
>  
> -STATIC void __exit
> +STATIC void
>  xfs_destroy_workqueues(void)
>  {
>       destroy_workqueue(xfs_ail_wq);
> 
> _______________________________________________
> xfs-masters mailing list
> xfs-masters@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs-masters
---end quoted text---

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [xfs-masters] [PATCH] xfs_destroy_workqueues() should not be tagged with __exit, Christoph Hellwig <=