Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue

xfs

Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue
From:	Alex Elder <aelder@xxxxxxx>
Date:	Thu, 07 Apr 2011 16:16:28 -0500
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1302141445-27457-6-git-send-email-david@xxxxxxxxxxxxx>
References:	<1302141445-27457-1-git-send-email-david@xxxxxxxxxxxxx> <1302141445-27457-6-git-send-email-david@xxxxxxxxxxxxx>
Reply-to:	aelder@xxxxxxx

On Thu, 2011-04-07 at 11:57 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Similar to the xfssyncd, the per-filesystem xfsaild threads can be
> converted to a global workqueue and run periodically by delayed
> works. This makes sense for the AIL pushing because it uses
> variable timeouts depending on the work that needs to be done.
> 
> By removing the xfsaild, we simplify the AIL pushing code and
> remove the need to spread the code to implement the threading
> and pushing across multiple files.

Pretty cool.  Looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 2/9] xfs: introduce a xfssyncd workqueue, (continued) Re: [PATCH 2/9] xfs: introduce a xfssyncd workqueue, Alex Elder Re: [PATCH 2/9] xfs: introduce a xfssyncd workqueue, Dave Chinner [PATCH 1/9] xfs: fix extent format buffer allocation size, Dave Chinner [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue, Dave Chinner Re: [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue, Alex Elder [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Dave Chinner Re: [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Alex Elder [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c, Dave Chinner Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c, Alex Elder [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue, Dave Chinner Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue, Alex Elder <= [PATCH 9/9] xfs: convert log tail checking to a warning, Dave Chinner Re: [PATCH 9/9] xfs: convert log tail checking to a warning, Alex Elder [PATCH 8/9] xfs: catch bad block numbers freeing extents., Dave Chinner Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents., Alex Elder

Previous by Date:	Re: [PATCH 4/9] xfs: introduce background inode reclaim work, Alex Elder
Next by Date:	Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c, Alex Elder
Previous by Thread:	[PATCH 5/9] xfs: convert the xfsaild threads to a workqueue, Dave Chinner
Next by Thread:	[PATCH 9/9] xfs: convert log tail checking to a warning, Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]