xfs
[Top] [All Lists]

Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 07 Apr 2011 16:16:28 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1302141445-27457-6-git-send-email-david@xxxxxxxxxxxxx>
References: <1302141445-27457-1-git-send-email-david@xxxxxxxxxxxxx> <1302141445-27457-6-git-send-email-david@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2011-04-07 at 11:57 +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> 
> Similar to the xfssyncd, the per-filesystem xfsaild threads can be
> converted to a global workqueue and run periodically by delayed
> works. This makes sense for the AIL pushing because it uses
> variable timeouts depending on the work that needs to be done.
> 
> By removing the xfsaild, we simplify the AIL pushing code and
> remove the need to spread the code to implement the threading
> and pushing across multiple files.

Pretty cool.  Looks good to me.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>


<Prev in Thread] Current Thread [Next in Thread>