xfs
[Top] [All Lists]

Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 7 Apr 2011 10:08:32 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110406181749.GC4356@xxxxxxxxxxxxx>
References: <1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-7-git-send-email-david@xxxxxxxxxxxxx> <20110406181749.GC4356@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Apr 06, 2011 at 02:17:49PM -0400, Christoph Hellwig wrote:
> > +/*
> > + * Return a pointer to the first item in the AIL.
> > + * If the AIL is empty, then return NULL.
> > + */
> 
> > +/*
> > + * Return a pointer to the item which follows
> > + * the given item in the AIL.  If the given item
> > + * is the last item in the list, then return NULL.
> > + */
> 
> These comment seem to line break strangely early.
> 
> > +   ASSERT((&next_lip->li_ail == &ailp->xa_ail) ||
> > +          (XFS_LSN_CMP(next_lip->li_lsn, lsn) <= 0));
> 
> no need for the inner braces here.
> 
> > +   list_splice_init(list, &next_lip->li_ail);
> > +   return;
> 
> and no need for the return.
> 
> 
> I know it's all nitpicking about pre-existing code, but when you touch
> it anyway it might make sense to tidy it up.

Makes sense, I'll clean them up.

Cheers,

Dave.

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>