xfs
[Top] [All Lists]

Re: [PATCH 4/9] xfs: introduce background inode reclaim work

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 4/9] xfs: introduce background inode reclaim work
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 7 Apr 2011 10:06:33 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110406181426.GB4356@xxxxxxxxxxxxx>
References: <1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-5-git-send-email-david@xxxxxxxxxxxxx> <20110406181426.GB4356@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Apr 06, 2011 at 02:14:26PM -0400, Christoph Hellwig wrote:
> > + * We can have inodes enter reclaim after we've shut down the syncd 
> > workqueue
> > + * during unmount, so don't allow reclaim work to be queued during unmount.
> 
> Nipick: this part of the comment would be better just above the
> MS_ACTIVE check.  I just tried to figure out what it was for, and it
> took me a while to realize the explanation was in the block comment
> above the function.

Will fix.

> > +static void
> > +xfs_syncd_queue_reclaim(
> > +   struct xfs_mount        *mp)
> > +{
> > +   if (!(mp->m_super->s_flags & MS_ACTIVE))
> > +           return;
> 
> Otherwise looks good.

I'll assume you meant to add a Reviewed-by tag there and include it
in the next posting.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>