xfs
[Top] [All Lists]

Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Apr 2011 14:17:49 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1302070758-17312-7-git-send-email-david@xxxxxxxxxxxxx>
References: <1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-7-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +/*
> + * Return a pointer to the first item in the AIL.
> + * If the AIL is empty, then return NULL.
> + */

> +/*
> + * Return a pointer to the item which follows
> + * the given item in the AIL.  If the given item
> + * is the last item in the list, then return NULL.
> + */

These comment seem to line break strangely early.

> +     ASSERT((&next_lip->li_ail == &ailp->xa_ail) ||
> +            (XFS_LSN_CMP(next_lip->li_lsn, lsn) <= 0));

no need for the inner braces here.

> +     list_splice_init(list, &next_lip->li_ail);
> +     return;

and no need for the return.


I know it's all nitpicking about pre-existing code, but when you touch
it anyway it might make sense to tidy it up.

<Prev in Thread] Current Thread [Next in Thread>