| To: | Dave Chinner <david@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 4/9] xfs: introduce background inode reclaim work |
| From: | Christoph Hellwig <hch@xxxxxxxxxxxxx> |
| Date: | Wed, 6 Apr 2011 14:14:26 -0400 |
| Cc: | xfs@xxxxxxxxxxx |
| In-reply-to: | <1302070758-17312-5-git-send-email-david@xxxxxxxxxxxxx> |
| References: | <1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-5-git-send-email-david@xxxxxxxxxxxxx> |
| User-agent: | Mutt/1.5.21 (2010-09-15) |
> + * We can have inodes enter reclaim after we've shut down the syncd workqueue
> + * during unmount, so don't allow reclaim work to be queued during unmount.
Nipick: this part of the comment would be better just above the
MS_ACTIVE check. I just tried to figure out what it was for, and it
took me a while to realize the explanation was in the block comment
above the function.
> +static void
> +xfs_syncd_queue_reclaim(
> + struct xfs_mount *mp)
> +{
> + if (!(mp->m_super->s_flags & MS_ACTIVE))
> + return;
Otherwise looks good.
|
| Previous by Date: | Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue, Christoph Hellwig |
|---|---|
| Next by Date: | Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c, Christoph Hellwig |
| Previous by Thread: | [PATCH 4/9] xfs: introduce background inode reclaim work, Dave Chinner |
| Next by Thread: | Re: [PATCH 4/9] xfs: introduce background inode reclaim work, Dave Chinner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |