[Top] [All Lists]

Re: [PATCH 9/9] xfs: convert log tail checking to a warning

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 9/9] xfs: convert log tail checking to a warning
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Apr 2011 10:02:57 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1302070758-17312-10-git-send-email-david@xxxxxxxxxxxxx>
References: <1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-10-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 06, 2011 at 04:19:18PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@xxxxxxxxxx>
> On the Power platform, the log tail debug checks fire excessively
> causing the system to panic early in testing. The debug checks are
> known to be racy, though on x86_64 there is no evidence that they
> trigger at all.
> We want to keep the checks active on debug systems to alert us to
> problems with log space accounting, but we need to reduce the impact
> of a racy check on testing on the Power platform.
> As a result, convert the ASSERT conditions to warnings, and
> allow them to fire only once per filesystem mount. This will prevent
> false positives from interfering with testing, whilst still
> providing us with the indication that they may be a problem with log
> space accounting should that occur.
> Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx>

Keeping a potentially racy debug check around still seems somewhat
fishy to me.  But you've done all the recent log work, so if it's
going to help you spot problems I'm fine with keeping it in this way,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>