Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents.

To:	Dave Chinner <david@xxxxxxxxxxxxx>
Subject:	Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents.
From:	Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date:	Wed, 6 Apr 2011 09:59:51 -0400
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<1302070758-17312-9-git-send-email-david@xxxxxxxxxxxxx>
References:	<1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-9-git-send-email-david@xxxxxxxxxxxxx>
User-agent:	Mutt/1.5.21 (2010-09-15)

> +     /* validate the extent size is legal now we have the agf locked */
> +     if (!args.agbp) {
> +             error = EFSCORRUPTED;
> +             goto error0;
> +     }

This is not a corruption case, but would require someone changing
xfs_fix_freelist and messing up.  I think the check can be removed
given that the potentially added bug would trivially trip up as
a NULL pointer dereference.

Otherwise looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, (continued) Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, Dave Chinner Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, Christoph Hellwig [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Dave Chinner Re: [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Christoph Hellwig Re: [PATCH 7/9] xfs: push the AIL from memory reclaim and periodic sync, Dave Chinner [PATCH 9/9] xfs: convert log tail checking to a warning, Dave Chinner Re: [PATCH 9/9] xfs: convert log tail checking to a warning, Christoph Hellwig Re: [PATCH 9/9] xfs: convert log tail checking to a warning, Dave Chinner [PATCH 3/9] xfs: convert ENOSPC inode flushing to use new syncd workqueue, Dave Chinner [PATCH 8/9] xfs: catch bad block numbers freeing extents., Dave Chinner Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents., Christoph Hellwig <= Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents., Dave Chinner [PATCH 4/9] xfs: introduce background inode reclaim work, Dave Chinner Re: [PATCH 4/9] xfs: introduce background inode reclaim work, Christoph Hellwig Re: [PATCH 4/9] xfs: introduce background inode reclaim work, Dave Chinner [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c, Dave Chinner Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c, Christoph Hellwig Re: [PATCH 6/9] xfs: clean up code layout in xfs_trans_ail.c, Dave Chinner [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue, Dave Chinner Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue, Christoph Hellwig Re: [PATCH 5/9] xfs: convert the xfsaild threads to a workqueue, Dave Chinner

Previous by Date:	Re: [PATCH 1/9] xfs: fix extent format buffer allocation size, Christoph Hellwig
Next by Date:	Re: [PATCH 9/9] xfs: convert log tail checking to a warning, Christoph Hellwig
Previous by Thread:	[PATCH 8/9] xfs: catch bad block numbers freeing extents., Dave Chinner
Next by Thread:	Re: [PATCH 8/9] xfs: catch bad block numbers freeing extents., Dave Chinner
Indexes:	[Date] [Thread] [Top] [All Lists]