xfs
[Top] [All Lists]

Re: [PATCH 1/9] xfs: fix extent format buffer allocation size

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/9] xfs: fix extent format buffer allocation size
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 6 Apr 2011 09:38:17 -0400
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1302070758-17312-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1302070758-17312-1-git-send-email-david@xxxxxxxxxxxxx> <1302070758-17312-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Apr 06, 2011 at 04:19:10PM +1000, Dave Chinner wrote:
> +     ext_buffer = kmem_alloc(XFS_IFORK_SIZE(ip, whichfork),
> +                                                     KM_SLEEP | KM_NOFS);

As mentioned before the KM_NOFS is a change from the previous version
and really should not be needed.

Also the feedback that the new helper needs to be under the
!XFS_NATIVE_ENDIAN ifdef wasn't picked up either.

<Prev in Thread] Current Thread [Next in Thread>