xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix variable set but not used warnings

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfs: fix variable set but not used warnings
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Tue, 5 Apr 2011 15:10:06 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1301941280.2630.61.camel@doink>
References: <20110404125544.GA726@xxxxxxxxxxxxx> <1301941280.2630.61.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Apr 04, 2011 at 01:21:20PM -0500, Alex Elder wrote:
> >     __int64_t       sbflags;
> >  
> >     flags &= (XFS_ALL_QUOTA_ACCT | XFS_ALL_QUOTA_ENFD);
> >     /*
> >      * Switching on quota accounting must be done at mount time.
> >      */
> > -   accflags = flags & XFS_ALL_QUOTA_ACCT;
> >     flags &= ~(XFS_ALL_QUOTA_ACCT);
> 
> Unrelated, but isn't the effect of this line plus the one a few
> lines up the same as this?
> 
>       flags &= XFS_ALL_QUOTA_ENFD;

Yes, it is.  I have a patch in my queue to clean this and a few others
bits around it up, but unlike the warnings fixes it's really 2.6.40
material.

<Prev in Thread] Current Thread [Next in Thread>