xfs
[Top] [All Lists]

Re: [PATCH] xfs: fix xfs_debug warnings

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] xfs: fix xfs_debug warnings
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 3 Apr 2011 10:16:48 +1000
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110402220905.GA1861@xxxxxxxxxxxxx>
References: <20110402181340.GA12639@xxxxxxxxxxxxx> <20110402220905.GA1861@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Sat, Apr 02, 2011 at 06:09:05PM -0400, Christoph Hellwig wrote:
> Err, the subject should have been:
> 
> [PATCH] xfs: fix xfs_debug warnings
> 
> On Sat, Apr 02, 2011 at 02:13:40PM -0400, Christoph Hellwig wrote:
> > For a CONFIG_XFS_DEBUG=n build gcc complains about statements with no
> > effect in xfs_debug:
> > 
> > fs/xfs/quota/xfs_qm_syscalls.c: In function 'xfs_qm_scall_trunc_qfiles':
> > fs/xfs/quota/xfs_qm_syscalls.c:291:3: warning: statement with no effect
> > 
> > The reason for that is that the various new xfs message functions have a
> > return value which is never used, and in case of the non-debug build
> > xfs_debug the macro evaluates to a plain 0 which produces the above
> > warnings.  This can be fixed by turning xfs_debug into an inline function
> > instead of a macro, but in addition to that I've also changed all the
> > message helpers to return void as we never use their return values.
> > 
> > Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good, though I don't get those warnings using gcc-4.4.4. I
guess it's gcc-4.6 issuing the warnings?

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>