Re: [PATCH] xfs: fix extent format buffer allocation size

[Dave Chinner <david@xxxxxxxxxxxxx>]

On Wed, Mar 30, 2011 at 05:33:34AM -0400, Christoph Hellwig wrote:
> > +   xfs_bmbt_rec_t          *ext_buffer;
> > +
> > +   ext_buffer = kmem_alloc(XFS_IFORK_SIZE(ip, whichfork),
> 
> If the fork size be the minimum of XFS_IFORK_SIZE and the if_bytes
> value?

I thought about that, but I don't think it makes any difference. If
there are no delalloc extents, then XFS_IFORK_SIZE and ifp->if_bytes
are identical when the fork is in extent format. If there are
delalloc extents, then XFS_IFORK_SIZE() is the one we want. Hence I
don't think we need to even consider the value of ifp->if_bytes at
all here....

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx