xfs
[Top] [All Lists]

Re: XFS memory allocation deadlock in 2.6.38

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: XFS memory allocation deadlock in 2.6.38
From: "'Christoph Hellwig'" <hch@xxxxxxxxxxxxx>
Date: Wed, 30 Mar 2011 05:30:41 -0400
Cc: Sean Noonan <Sean.Noonan@xxxxxxxxxxxx>, "'Christoph Hellwig'" <hch@xxxxxxxxxxxxx>, "'Michel Lespinasse'" <walken@xxxxxxxxxx>, "'linux-kernel@xxxxxxxxxxxxxxx'" <linux-kernel@xxxxxxxxxxxxxxx>, Martin Bligh <Martin.Bligh@xxxxxxxxxxxx>, Trammell Hudson <Trammell.Hudson@xxxxxxxxxxxx>, Christos Zoulas <Christos.Zoulas@xxxxxxxxxxxx>, "'linux-xfs@xxxxxxxxxxx'" <linux-xfs@xxxxxxxxxxx>, Stephen Degler <Stephen.Degler@xxxxxxxxxxxx>, "'linux-mm@xxxxxxxxx'" <linux-mm@xxxxxxxxx>
In-reply-to: <20110330000942.GI3008@dastard>
References: <081DDE43F61F3D43929A181B477DCA95639B5327@xxxxxxxxxxxxxxxxxxxx> <20110324174311.GA31576@xxxxxxxxxxxxx> <AANLkTikwwRm6FHFtEdUg54NvmKdswQw-NPH5dtq1mXBK@xxxxxxxxxxxxxx> <081DDE43F61F3D43929A181B477DCA95639B5349@xxxxxxxxxxxxxxxxxxxx> <BANLkTin0jJevStg5P2hqsLbqMzo3o30sYg@xxxxxxxxxxxxxx> <081DDE43F61F3D43929A181B477DCA95639B534E@xxxxxxxxxxxxxxxxxxxx> <081DDE43F61F3D43929A181B477DCA95639B5359@xxxxxxxxxxxxxxxxxxxx> <20110329192434.GA10536@xxxxxxxxxxxxx> <081DDE43F61F3D43929A181B477DCA95639B535D@xxxxxxxxxxxxxxxxxxxx> <20110330000942.GI3008@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 30, 2011 at 11:09:42AM +1100, Dave Chinner wrote:
> +     ext_buffer = kmem_alloc(XFS_IFORK_SIZE(ip, whichfork),
> +                                                     KM_SLEEP | KM_NOFS);

The old code didn't use KM_NOFS, and I don't think it needed it either,
as we call the iop_format handlers inside the region covered by the
PF_FSTRANS flag.

Also I think the   routine needs to be under #ifndef XFS_NATIVE_HOST, as
we do not use it for big endian builds.

<Prev in Thread] Current Thread [Next in Thread>