[Top] [All Lists]

Re: [PATCH 3/5] xfs: exact busy extent tracking

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/5] xfs: exact busy extent tracking
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 29 Mar 2011 14:04:22 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110328210914.996696705@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110328210614.832613417@xxxxxxxxxxxxxxxxxxxxxx> <20110328210914.996696705@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2011-03-28 at 17:06 -0400, Christoph Hellwig wrote:
> Update the extent tree in case we have to reuse a busy extent, so that it
> always is kept uptodate.  This is done by replacing the busy list searches
> with a new xfs_alloc_busy_reuse helper, which updates the busy extent tree
> in case of a reuse.   Also replace setting transactions to sync with forcing
> the log out in case we found a busy extent to reuse.  This makes the code a
> lot more simple, and is required for discard support later on.  While it
> will cause performance regressios with just this patch applied, the impact
> is more than mitigated by the next patch in the series.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.  xfs_alloc_busy_update_extent() is a better name
than xfs_alloc_buisy_try_reuse() was.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>