[Top] [All Lists]

Re: [PATCH 1/5] xfs: optimize AGFL refills

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: optimize AGFL refills
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 29 Mar 2011 14:04:11 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110328210914.594997356@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110328210614.832613417@xxxxxxxxxxxxxxxxxxxxxx> <20110328210914.594997356@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2011-03-28 at 17:06 -0400, Christoph Hellwig wrote:
> While we need to make sure we do not reuse busy extents, there is no need
> to force out busy extents when moving them between the AGFL and the
> freespace btree as we still take care of that when doing the real allocation.
> To avoid the log force when just moving extents from the different free
> space tracking structures, move the busy search out of
> xfs_alloc_get_freelist into the callers that need it, and move the busy
> list insert from xfs_free_ag_extent which is used both by AGFL refills
> and real allocation to xfs_free_extent, which is only used by the latter.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

<Prev in Thread] Current Thread [Next in Thread>