xfs
[Top] [All Lists]

Re: [PATCH] xfs: cleanup duplicate initializations

To: David Sterba <dsterba@xxxxxxx>
Subject: Re: [PATCH] xfs: cleanup duplicate initializations
From: Alex Elder <aelder@xxxxxxx>
Date: Mon, 28 Mar 2011 13:52:50 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1301332373-24914-1-git-send-email-dsterba@xxxxxxx>
References: <1301332373-24914-1-git-send-email-dsterba@xxxxxxx>
Reply-to: aelder@xxxxxxx
On Mon, 2011-03-28 at 19:12 +0200, David Sterba wrote:
> follow these guidelines:
> - leave initialization in the declaration block if it fits the line
> - move to the code where it's more suitable ('for' init block)
> 
> Signed-off-by: David Sterba <dsterba@xxxxxxx>

Looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>