xfs
[Top] [All Lists]

Re: [PATCH 1/6] xfs: optimize AGFL refills

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] xfs: optimize AGFL refills
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 25 Mar 2011 16:03:01 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110323121613.GA468@xxxxxxxxxxxxx>
References: <20110322195550.260682574@xxxxxxxxxxxxxxxxxxxxxx> <20110322200137.280301318@xxxxxxxxxxxxxxxxxxxxxx> <1300833051.2875.275.camel@doink> <20110323121613.GA468@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Wed, 2011-03-23 at 08:16 -0400, Christoph Hellwig wrote: 
> On Tue, Mar 22, 2011 at 05:30:51PM -0500, Alex Elder wrote:
> > On Tue, 2011-03-22 at 15:55 -0400, Christoph Hellwig wrote:
> > > Avoid forcing out busy extent when moving blocks from/to the AGFL.  We
> > 
> > Without thinking a bit about it, it wasn't clear why doing
> > this was OK to do.  It would be nice to record a one-sentence
> > justification of why we don't need to force busy extents out
> > in this case.
> 
> I've added a sentence, but it seems rather pointless.

The reason it was not obvious is because the case you're
treating is specifically when moving extents (blocks,
really) between the free list and the free btrees, in
xfs_alloc_fix_freelist().  You still need to force it
out when allocating and freeing "actually used" blocks,
which could also be considered "moving blocks from/to
the AGFL."

                                        -Alex


> >  achieve this
> 
> fixed.
> 
> > > the callers that need it, and by moving the busy list insert from
> > > xfs_free_ag_extent extent which is used both by AGFL refills and real
> >                      ^^^^^ drop this word
> 
> fixed.
> 




<Prev in Thread] Current Thread [Next in Thread>