xfs
[Top] [All Lists]

Re: [PATCH V2] xfstests 249: use -F option for xfs_io

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH V2] xfstests 249: use -F option for xfs_io
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 24 Mar 2011 09:50:29 +1100
Cc: xfs-oss <xfs@xxxxxxxxxxx>
In-reply-to: <4D8A19D4.3080807@xxxxxxxxxx>
References: <4D8A1795.3080401@xxxxxxxxxx> <4D8A19D4.3080807@xxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Wed, Mar 23, 2011 at 11:03:32AM -0500, Eric Sandeen wrote:
> Test 249 was appearing to pass on ext4, but it wasn't really
> exercising the test due to lack of "-F" in the xfs_io arguments.
> 
> Without -F the files were created (oddly enough); neither pwrite
> nor sendfile were executed, and the diff of the two (empty)
> files passed, resulting in a passed test without testing anything.
> 
> So add the -F, capture the output, and test the result of each
> xfs_io invocation.

Ok.

> Also, when it fails, the diff output is huge.  Make diff silent,
> but describe the diff failure and exit.

Excellent - I was going to suggest this myself given you were
touching this test.

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>