[Top] [All Lists]

[PATCH V2] xfstests 249: use -F option for xfs_io

To: xfs-oss <xfs@xxxxxxxxxxx>
Subject: [PATCH V2] xfstests 249: use -F option for xfs_io
From: Eric Sandeen <sandeen@xxxxxxxxxx>
Date: Wed, 23 Mar 2011 11:03:32 -0500
In-reply-to: <4D8A1795.3080401@xxxxxxxxxx>
References: <4D8A1795.3080401@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv: Gecko/20110303 Thunderbird/3.1.9
Test 249 was appearing to pass on ext4, but it wasn't really
exercising the test due to lack of "-F" in the xfs_io arguments.

Without -F the files were created (oddly enough); neither pwrite
nor sendfile were executed, and the diff of the two (empty)
files passed, resulting in a passed test without testing anything.

So add the -F, capture the output, and test the result of each
xfs_io invocation.

Also, when it fails, the diff output is huge.  Make diff silent,
but describe the diff failure and exit.

Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

V2: change diff to diff -q

diff --git a/249 b/249
old mode 100644
new mode 100755
index 6fc972e..100cd4c
--- a/249
+++ b/249
@@ -52,11 +52,15 @@ echo "Feel the serenity."
+rm -f $seq.full
-$XFS_IO_PROG -f -c "pwrite -S 0xa5a55a5a 0 32768k" -c fsync $SRC > /dev/null 
-$XFS_IO_PROG -f -c "sendfile -i $SRC 0 32768k" -c fsync $DST > /dev/null 2>&1
-diff $SRC $DST
+$XFS_IO_PROG -F -f -c "pwrite -S 0xa5a55a5a 0 32768k" -c fsync $SRC >> 
$seq.full 2>&1
+[ $? -ne 0 ] && _fail "xfs_io pwrite failed"
+$XFS_IO_PROG -F -f -c "sendfile -i $SRC 0 32768k" -c fsync $DST >> $seq.full 
+[ $? -ne 0 ] && _fail "xfs_io sendfile failed"
+diff -q $SRC $DST
+[ $status -ne 0 ] && _fail "$SRC and $DST differ"

<Prev in Thread] Current Thread [Next in Thread>