[Top] [All Lists]

Re: [PATCH 1/6] xfs: optimize AGFL refills

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] xfs: optimize AGFL refills
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 23 Mar 2011 08:16:38 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110322233054.GD15270@dastard>
References: <20110322195550.260682574@xxxxxxxxxxxxxxxxxxxxxx> <20110322200137.280301318@xxxxxxxxxxxxxxxxxxxxxx> <20110322233054.GD15270@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Wed, Mar 23, 2011 at 10:30:54AM +1100, Dave Chinner wrote:
> > +   if (error)
> > +           xfs_alloc_busy_insert(tp, args.agno, args.agbno, len);
> Shouldn't that be "if (!error)"?  i.e. if we freed the extent
> successfully we need to insert it in the busy list. This current
> code has the effect of never inserting freed data extents in the
> busy list....

Yes, it should.  This got messed up at some point during reshuffling
the series.

<Prev in Thread] Current Thread [Next in Thread>