[Top] [All Lists]

Re: [PATCH 2/6] xfs: do not immediately reuse busy extent ranges

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 2/6] xfs: do not immediately reuse busy extent ranges
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 22 Mar 2011 17:30:59 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110322200137.474878707@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110322195550.260682574@xxxxxxxxxxxxxxxxxxxxxx> <20110322200137.474878707@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2011-03-22 at 15:55 -0400, Christoph Hellwig wrote:
> plain text document attachment (xfs-skip-busy-extents)
> Every time we reallocate a busy extent, we cause a synchronous log force
> to occur to ensure the freeing transaction is on disk before we continue
> and use the newly allocated extent.  This is extremely sub-optimal as we
> have to mark every transaction with blocks that get reused as synchronous.
> Instead of searching the busy extent list after deciding on the extent to
> allocate, check each candidate extent during the allocation decisions as
> to whether they are in the busy list.  If they are in the busy list, we
> trim the busy range out of the extent we have found and determine if that
> trimmed range is still OK for allocation. In many cases, this check can
> be incorporated into the allocation extent alignment code which already
> does trimming of the found extent before determining if it is a valid
> candidate for allocation.
> Based on two earlier patches from Dave Chinner.

Again, this looks nearly identical to your last version.
On that one, I suggested rewording a comment, and you
said "ok."  You did not do so in this version, which I
guess is fine.  I just want to know whether you intended
to.  If so I'll give you a chance to post an update; if
not I can take this one as-is.

(I think I'll have the rest of the series reviewed tomorrow.)

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

. . .

<Prev in Thread] Current Thread [Next in Thread>