[Top] [All Lists]

Re: [PATCH 1/6] xfs: optimize AGFL refills

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/6] xfs: optimize AGFL refills
From: Alex Elder <aelder@xxxxxxx>
Date: Tue, 22 Mar 2011 17:30:51 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110322200137.280301318@xxxxxxxxxxxxxxxxxxxxxx>
References: <20110322195550.260682574@xxxxxxxxxxxxxxxxxxxxxx> <20110322200137.280301318@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Tue, 2011-03-22 at 15:55 -0400, Christoph Hellwig wrote:
> Avoid forcing out busy extent when moving blocks from/to the AGFL.  We

Without thinking a bit about it, it wasn't clear why doing
this was OK to do.  It would be nice to record a one-sentence
justification of why we don't need to force busy extents out
in this case.

> archive this my moving the busy search out of xfs_alloc_get_freelist into

 achieve this

> the callers that need it, and by moving the busy list insert from
> xfs_free_ag_extent extent which is used both by AGFL refills and real
                     ^^^^^ drop this word

> allocation to xfs_free_extent, which is only used by the latter.
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Otherwise the change itself looks good.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

. . .

<Prev in Thread] Current Thread [Next in Thread>