xfs
[Top] [All Lists]

Re: [PATCH 5/6] xfs: convert the xfsaild threads to a workqueue

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 5/6] xfs: convert the xfsaild threads to a workqueue
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Sat, 19 Mar 2011 09:45:00 -0400
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <20110318040648.GG30195@dastard>
References: <1299715529-11026-1-git-send-email-david@xxxxxxxxxxxxx> <1299715529-11026-6-git-send-email-david@xxxxxxxxxxxxx> <20110310174818.GE19609@xxxxxxxxxxxxx> <20110318040648.GG30195@dastard>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 18, 2011 at 03:06:48PM +1100, Dave Chinner wrote:
> It gets used by a second caller in the next patch that uses a
> timeout of zero. The idea of adding a delay to a normal push is to
> rate limit the number of times we do work so we always work on
> batches rather a few items at a time in multiple executions of the
> work.
>
> I'll see if it's simpler to just do this work directly in teh
> callers, though.

I don't think hiding this delay (uncommented) in the workqueue use is
a good idea.  xlog_grant_push_ail has all the logics about when to push
the AIL, so any batching should be grouped with that logic, and
documented there.  It in fact already has some comments static that
a min/max watermark scheme would be useful.

<Prev in Thread] Current Thread [Next in Thread>