xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd work

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd workqueue
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Fri, 18 Mar 2011 14:39:36 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110310173549.GC19609@xxxxxxxxxxxxx>
References: <1299715529-11026-1-git-send-email-david@xxxxxxxxxxxxx> <1299715529-11026-4-git-send-email-david@xxxxxxxxxxxxx> <20110310173549.GC19609@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Thu, Mar 10, 2011 at 12:35:49PM -0500, Christoph Hellwig wrote:
> Looks good,
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 
> > +STATIC void
> > +xfs_flush_worker(
> > +   struct work_struct *work)
> > +{
> > +   struct xfs_mount *mp = container_of(work,
> > +                                   struct xfs_mount, m_flush_work);
> > +
> > +   xfs_sync_data(mp, SYNC_TRYLOCK);
> > +   xfs_sync_data(mp, SYNC_TRYLOCK | SYNC_WAIT);
> > +   xfs_log_force(mp, XFS_LOG_SYNC);
> 
> No actually new in this patch: but what's the point of the log force
> here?  xfs_sync_data just did one before returning.

Historical, I think. Removed.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>