xfs
[Top] [All Lists]

Re: [PATCH] xfs: don't name variables "panic"

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfs: don't name variables "panic"
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Sun, 13 Mar 2011 11:49:00 +1100
Cc: XFS Mailing List <xfs@xxxxxxxxxxx>, Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
In-reply-to: <1299847191.3462.1.camel@doink>
References: <AANLkTi=Hg4s5kEMQZu_KGePf4W_7jAFm0_WifM9W3PR6@xxxxxxxxxxxxxx> <1299847191.3462.1.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Mar 11, 2011 at 06:39:51AM -0600, Alex Elder wrote:
> The new xfs_alert_tag() used a variable named "panic",
> and that is to be avoided.  Rename it.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

My fault. Fix looks good.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

Cheers,

Dave
-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>