xfs
[Top] [All Lists]

[PATCH] xfs: don't name variables "panic"

To: XFS Mailing List <xfs@xxxxxxxxxxx>
Subject: [PATCH] xfs: don't name variables "panic"
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 11 Mar 2011 06:39:51 -0600
Cc: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
In-reply-to: <AANLkTi=Hg4s5kEMQZu_KGePf4W_7jAFm0_WifM9W3PR6@xxxxxxxxxxxxxx>
References: <AANLkTi=Hg4s5kEMQZu_KGePf4W_7jAFm0_WifM9W3PR6@xxxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
The new xfs_alert_tag() used a variable named "panic",
and that is to be avoided.  Rename it.

Signed-off-by: Alex Elder <aelder@xxxxxxx>

---
 fs/xfs/linux-2.6/xfs_message.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Index: b/fs/xfs/linux-2.6/xfs_message.c
===================================================================
--- a/fs/xfs/linux-2.6/xfs_message.c
+++ b/fs/xfs/linux-2.6/xfs_message.c
@@ -96,13 +96,13 @@ xfs_alert_tag(
 {
        struct va_format        vaf;
        va_list                 args;
-       int                     panic = 0;
+       int                     do_panic = 0;
        int                      r;

        if (xfs_panic_mask && (xfs_panic_mask & panic_tag)) {
                xfs_printk(KERN_ALERT, mp,
                        "XFS: Transforming an alert into a BUG.");
-               panic = 1;
+               do_panic = 1;
        }

        va_start(args, fmt);
@@ -113,7 +113,7 @@ xfs_alert_tag(
        r = __xfs_printk(KERN_ALERT, mp, &vaf);
        va_end(args);

-       BUG_ON(panic);
+       BUG_ON(do_panic);

        return r;
 }


<Prev in Thread] Current Thread [Next in Thread>