xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstests: a few fixes to Makefile

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 1/2] xfstests: a few fixes to Makefile
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Fri, 11 Mar 2011 05:10:20 -0500
Cc: Christoph Hellwig <hch@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1299795366.2573.78.camel@doink>
References: <201103041937.p24JbaaN004813@xxxxxxxxxxxxxxxxxxxxxx> <20110310172537.GB13390@xxxxxxxxxxxxx> <1299795366.2573.78.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Thu, Mar 10, 2011 at 04:16:06PM -0600, Alex Elder wrote:
> On Thu, 2011-03-10 at 12:25 -0500, Christoph Hellwig wrote:
> > > +ifeq ($(HAVE_DMAPI), true)
> > >   # automake doesn't always support "default" target 
> > >   # so do dmapi make explicitly with "all"
> > > -ifeq ($(HAVE_DMAPI), true)
> > 
> > What about moving the # signs to the first line so that it never gets
> > echoed at all?
> > 
> > Otherwise looks good to me.
> 
> That would work too.  A later patch makes the
> whole thing go away though, so it's sort of moot.
> (And I already committed it after some discussion
> with Eric yesterday...)

Ok.

<Prev in Thread] Current Thread [Next in Thread>