xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstests: a few fixes to Makefile

To: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstests: a few fixes to Makefile
From: Alex Elder <aelder@xxxxxxx>
Date: Thu, 10 Mar 2011 16:16:06 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <20110310172537.GB13390@xxxxxxxxxxxxx>
References: <201103041937.p24JbaaN004813@xxxxxxxxxxxxxxxxxxxxxx> <20110310172537.GB13390@xxxxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2011-03-10 at 12:25 -0500, Christoph Hellwig wrote:
> > +ifeq ($(HAVE_DMAPI), true)
> >     # automake doesn't always support "default" target 
> >     # so do dmapi make explicitly with "all"
> > -ifeq ($(HAVE_DMAPI), true)
> 
> What about moving the # signs to the first line so that it never gets
> echoed at all?
> 
> Otherwise looks good to me.

That would work too.  A later patch makes the
whole thing go away though, so it's sort of moot.
(And I already committed it after some discussion
with Eric yesterday...)

                                        -Alex

<Prev in Thread] Current Thread [Next in Thread>