xfs
[Top] [All Lists]

Re: [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd work

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 3/6] xfs: convert ENOSPC inode flushing to use new syncd workqueue
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2011 12:35:49 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1299715529-11026-4-git-send-email-david@xxxxxxxxxxxxx>
References: <1299715529-11026-1-git-send-email-david@xxxxxxxxxxxxx> <1299715529-11026-4-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

> +STATIC void
> +xfs_flush_worker(
> +     struct work_struct *work)
> +{
> +     struct xfs_mount *mp = container_of(work,
> +                                     struct xfs_mount, m_flush_work);
> +
> +     xfs_sync_data(mp, SYNC_TRYLOCK);
> +     xfs_sync_data(mp, SYNC_TRYLOCK | SYNC_WAIT);
> +     xfs_log_force(mp, XFS_LOG_SYNC);

No actually new in this patch: but what's the point of the log force
here?  xfs_sync_data just did one before returning.

<Prev in Thread] Current Thread [Next in Thread>