xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix parallel make

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: fix parallel make
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2011 12:30:25 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201103042235.p24MZ75i023399@xxxxxxxxxxxxxxxxxxxxxx>
References: <201103042235.p24MZ75i023399@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 04, 2011 at 04:35:07PM -0600, Alex Elder wrote:
> Having both "include/builddefs" and "include/config.h" as
> dependencies for the default target results in a parallel
> invocation of "make" spawning two concurrent attempts to
> do the configure step--and that doesn't work.
> 
> Creating one of those two will result in the other getting
> created, so there's no need to list both as dependencies.
> 
> There are several other mysterious dependencies that serve
> no purpose, so get rid of them.


Looks good,

Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>