xfs
[Top] [All Lists]

Re: [PATCH] xfstests: rework "dmapi" subtree build mechanism

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: rework "dmapi" subtree build mechanism
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2011 12:29:43 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201103041937.p24Jbk5W004828@xxxxxxxxxxxxxxxxxxxxxx>
References: <201103041937.p24Jbk5W004828@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
>  LIB_SUBDIRS = include lib
>  TOOL_SUBDIRS = ltp src m4
> +ifeq ($(HAVE_DMAPI), true)
> +TOOL_SUBDIRS += dmapi
> +endif

Does this work with the way we generate source tarballs on make dist?
In xfsprogs we have special variables for source files that don't get
build.

> @@ -0,0 +1,30 @@
> +#
> +# Copyright (c) 2011 SGI  All Rights Reserved.
> +#

I think a license would be more useful than all rights reserved here.

Except for that the patch looks sane to me, and having a consistent
build system is a good thing.

<Prev in Thread] Current Thread [Next in Thread>