xfs
[Top] [All Lists]

Re: [PATCH 2/2] xfstests: some refinements on "make depend"

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 2/2] xfstests: some refinements on "make depend"
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2011 12:26:45 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201103041937.p24Jbfh5004820@xxxxxxxxxxxxxxxxxxxxxx>
References: <201103041937.p24Jbfh5004820@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
On Fri, Mar 04, 2011 at 01:37:41PM -0600, Alex Elder wrote:
> Make it so "make depend" is a generic target, like "make clean".
> 
> Each Makefile has a "depend" target that indicates whether making
> dependencies means creating ".dep" or creating ".ltdep" (or, I
> suppose, both, though none do that right now).  Both files get
> created even if there are no CFILES to scan (to ensure the target
> up-to-date).  The "default" target now depends on "depend" (there is
> no "ltdepend" any more).
> 
> Remove the "depend" and "ltdepend" definitions from the "buildrules"
> file; only the actual generated files (".dep" and ".ltdep") remain
> as generic targets.  The "depend' target is still defined as phony.
>  
> Do a shell trick when expanding the value of CFILES, to avoid a
> problem that occurs if it is created by "make" by concatentating two
> empty strings.  The problem was that in that case CFILES will
> contain a space, and that wasn't getting treated as empty as
> desired.
> 
> Make the rule for tool/lib dependencies more generic, to reflect the
> general desire that "lib" subdirectories need to be built before
> things in the "tool" subdirectories.

Can we instead port over the generic dependency generation from
xfsprogs/xfsdump?

<Prev in Thread] Current Thread [Next in Thread>