xfs
[Top] [All Lists]

Re: [PATCH] xfstests: fix a few build warnings

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: fix a few build warnings
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 10 Mar 2011 12:24:18 -0500
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201103041937.p24JbVtP004804@xxxxxxxxxxxxxxxxxxxxxx>
References: <201103041937.p24JbVtP004804@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
>  lio_random_methods(long curr_mask)
>  {
>      int mask=0;
> -    long random_bit();
> +    long random_bit(long);

This should use the prototype from include/random_range.h instead.

Otherwise looks good to me,


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

<Prev in Thread] Current Thread [Next in Thread>