xfs
[Top] [All Lists]

Re: [PATCH] xfstests: make 127 and 134 clean up after themselves

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH] xfstests: make 127 and 134 clean up after themselves
From: Eric Sandeen <sandeen@xxxxxxxxxxx>
Date: Wed, 09 Mar 2011 11:30:23 -0600
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201103042022.p24KMAss008218@xxxxxxxxxxxxxxxxxxxxxx>
References: <201103042022.p24KMAss008218@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9
On 3/4/11 2:22 PM, Alex Elder wrote:
> Tests 127 and 134 leave temp files around when they complete.
> Fix (or enable) their cleanup functions to remedy this.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Weird, 134 had the trap commented out from the initial commit...

Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxxx>

> ---
>  127 |    1 +
>  134 |    3 +--
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> Index: b/127
> ===================================================================
> --- a/127
> +++ b/127
> @@ -38,6 +38,7 @@ trap "_cleanup; exit \$status" 0 1 2 3 1
>  
>  _cleanup()
>  {
> +    rm -f $tmp.output
>      _cleanup_testdir
>  }
>  
> Index: b/134
> ===================================================================
> --- a/134
> +++ b/134
> @@ -43,8 +43,7 @@ _cleanup()
>       umount $SCRATCH_MNT 2>/dev/null
>       rm -f $tmp.*
>  }
> -#trap "_cleanup; exit \$status" 0 1 2 3 15
> -
> +trap "_cleanup; exit \$status" 0 1 2 3 15
>  
>  # real QA test starts here
>  _supported_fs xfs
> 
> _______________________________________________
> xfs mailing list
> xfs@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/xfs
> 

<Prev in Thread] Current Thread [Next in Thread>