xfs
[Top] [All Lists]

Re: [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH 0/3] xfsprogs: sync up with 2.6.38 kernel code V2
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Mon, 7 Mar 2011 13:24:31 -0500
Cc: Dave Chinner <david@xxxxxxxxxxxxx>, xfs@xxxxxxxxxxx
In-reply-to: <1299521684.2578.457.camel@doink>
References: <1294649091-27174-1-git-send-email-david@xxxxxxxxxxxxx> <20110214063042.GL2559@dastard> <1299521684.2578.457.camel@doink>
User-agent: Mutt/1.5.21 (2010-09-15)
On Mon, Mar 07, 2011 at 12:14:44PM -0600, Alex Elder wrote:
> 3) Why are you dropping the use of the symbols
>    XFS_DINODE_VERSION_1 and XFS_DINODE_VERSION_2 in
>   favor of just using 1 and 2?  (I guess I'm OK with
>   it, but wanted to call it out anyway.)

Because we dropped them from the kernel a while ago.  The removal
in kernel land was my patch and the reason is that it simply doesn't buy
anything over using the numerical constants.

> - XFS_IOC_FREEZE and XFS_IOC_THAW are still defined in
>   this version.  The code that uses it here could possibly
>   be converted to use the Linux generic FIFREEZE and FITHAW
>   instead.

That would require all users to include <linux/fs.h> first.  

<Prev in Thread] Current Thread [Next in Thread>