xfs
[Top] [All Lists]

Re: [PATCH 1/5] xfs: introduce inode cluster buffer trylocks for xfs_ifl

To: Dave Chinner <david@xxxxxxxxxxxxx>
Subject: Re: [PATCH 1/5] xfs: introduce inode cluster buffer trylocks for xfs_iflush
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 3 Mar 2011 10:55:35 -0500
Cc: xfs@xxxxxxxxxxx, chris.mason@xxxxxxxxxx
In-reply-to: <1298412969-14389-2-git-send-email-david@xxxxxxxxxxxxx>
References: <1298412969-14389-1-git-send-email-david@xxxxxxxxxxxxx> <1298412969-14389-2-git-send-email-david@xxxxxxxxxxxxx>
User-agent: Mutt/1.5.21 (2010-09-15)
> +      * pass through will see the stale flag set on the inode.
> +      */
> +     error = xfs_iflush(ip, SYNC_TRYLOCK | sync_mode);
>       if (sync_mode & SYNC_WAIT) {
> +             if (error == EAGAIN) {
> +                     xfs_iunlock(ip, XFS_ILOCK_EXCL);
> +                     /* backoff longer than in xfs_ifree_cluster */
> +                     delay(2);

Do we really need the delay here?  It seems like we'd rather want to
keep going with scanning the next inode cluster and return here from
xfs_reclaim_inodes.

> diff --git a/fs/xfs/linux-2.6/xfs_sync.h b/fs/xfs/linux-2.6/xfs_sync.h
> index 32ba662..0ae48ff 100644
> --- a/fs/xfs/linux-2.6/xfs_sync.h
> +++ b/fs/xfs/linux-2.6/xfs_sync.h
> @@ -34,6 +34,7 @@ typedef struct xfs_sync_work {
>  
>  int xfs_syncd_init(struct xfs_mount *mp);
>  void xfs_syncd_stop(struct xfs_mount *mp);
> +void xfs_syncd_queue_sync(struct xfs_mount *mp, int flags);

This hunk belongs into a different patch.

<Prev in Thread] Current Thread [Next in Thread>