xfs
[Top] [All Lists]

Re: [PATCH v4, 13/16] xfsprogs: metadump: move duplicate name handling i

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH v4, 13/16] xfsprogs: metadump: move duplicate name handling into its own function
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 3 Mar 2011 15:59:58 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <1298657628.1990.6987.camel@doink>
References: <201102182121.p1ILL2pI029171@xxxxxxxxxxxxxxxxxxxxxx> <20110224021239.GA3166@dastard> <1298657628.1990.6987.camel@doink>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Feb 25, 2011 at 12:13:48PM -0600, Alex Elder wrote:
> Move the handling of duplicate names into its own function.  As a
> result, all names other than "lost+found" files (not just those that
> get obfuscated) will be checked to avoid duplication.
> 
> This makes the local buffer newname[] in generate_obfuscated_name()
> unnecessary, so just drop it and use the passed-in name.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>
> 
> Updates:
> - A comment about handling of a leading '/' character is now modified
>   to match the updated code, rather than being deleted altogether.
> - Renamed handle_duplicates() to be handle_duplicate_name().

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [PATCH v4, 13/16] xfsprogs: metadump: move duplicate name handling into its own function, Dave Chinner <=