xfs
[Top] [All Lists]

Re: [PATCH 2/2 V2] xfstests 225: add additional fiemap-tester run withou

To: Eric Sandeen <sandeen@xxxxxxxxxxx>
Subject: Re: [PATCH 2/2 V2] xfstests 225: add additional fiemap-tester run without sync
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 25 Feb 2011 14:47:55 -0600
Cc: Eric Sandeen <sandeen@xxxxxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxx>, xfs mailing list <xfs@xxxxxxxxxxx>
In-reply-to: <4D66D8F2.10501@xxxxxxxxxxx>
References: <4D66D5DB.5090203@xxxxxxxxxx> <4D66D8F2.10501@xxxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2011-02-24 at 16:17 -0600, Eric Sandeen wrote:
> Chris Mason pointed out that some filesystems were not doing
> the right thing on fiemap, in the face of delalloc extents.
> 
> Because test 225 ran with FIEMAP_FLAG_SYNC only, this didn't
> get caught.  Add a runtime option, and run it both ways.
> 
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>

Looks good.  Please add a line to document the option
in the usage() function as suggested by Josef before
committing.

Reviewed-by: Alex Elder <aelder@xxxxxxx>



<Prev in Thread] Current Thread [Next in Thread>