xfs
[Top] [All Lists]

Re: [PATCH 1/2] xfstests: fix fiemap-tester for fewer extents returned

To: Eric Sandeen <sandeen@xxxxxxxxxx>
Subject: Re: [PATCH 1/2] xfstests: fix fiemap-tester for fewer extents returned
From: Alex Elder <aelder@xxxxxxx>
Date: Fri, 25 Feb 2011 14:47:47 -0600
Cc: xfs mailing list <xfs@xxxxxxxxxxx>, Josef Bacik <jbacik@xxxxxxxxxx>
In-reply-to: <4D66D55E.8070209@xxxxxxxxxx>
References: <4D66D55E.8070209@xxxxxxxxxx>
Reply-to: aelder@xxxxxxx
On Thu, 2011-02-24 at 16:02 -0600, Eric Sandeen wrote:
> If the fiemap call returns fewer extents than asked for,
> the fiemap tester gets confused.  If this happens, advance,
> and call fiemap again for the next offset.
> 
> XFS exposed this because if a file is all-delalloc, it was
> only returning 1 mapped extent (this is probably also a buglet).

Looks good.  I presume you mean we should get back
an array of delalloc extents, right?  I started
looking at why only one is returned but haven't
found it yet.

Reviewed-by: Alex Elder <aelder@xxxxxxx>

> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>


<Prev in Thread] Current Thread [Next in Thread>