xfs
[Top] [All Lists]

Re: [PATCH v3, 12/16] xfsprogs: metadump: no need for local copy of name

To: Alex Elder <aelder@xxxxxxx>
Subject: Re: [PATCH v3, 12/16] xfsprogs: metadump: no need for local copy of name when obfuscating
From: Dave Chinner <david@xxxxxxxxxxxxx>
Date: Thu, 24 Feb 2011 13:04:55 +1100
Cc: xfs@xxxxxxxxxxx
In-reply-to: <201102182121.p1ILL23t029159@xxxxxxxxxxxxxxxxxxxxxx>
References: <201102182121.p1ILL23t029159@xxxxxxxxxxxxxxxxxxxxxx>
User-agent: Mutt/1.5.20 (2009-06-14)
On Fri, Feb 18, 2011 at 03:21:02PM -0600, Alex Elder wrote:
> The local "newname" buffer in obfuscate_name() is used to hold
> an obfuscated name as it gets generated.  But it is always copied
> back into the passed-in name buffer, so we might as well just use
> the name buffer passed directly and avoid the copy.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

<Prev in Thread] Current Thread [Next in Thread>