Re: [PATCH v3, 06/16] xfsprogs: metadump: replace repeated blocks with a

xfs

Re: [PATCH v3, 06/16] xfsprogs: metadump: replace repeated blocks with a

To:	Alex Elder <aelder@xxxxxxx>
Subject:	Re: [PATCH v3, 06/16] xfsprogs: metadump: replace repeated blocks with a loop
From:	Dave Chinner <david@xxxxxxxxxxxxx>
Date:	Thu, 24 Feb 2011 12:40:30 +1100
Cc:	xfs@xxxxxxxxxxx
In-reply-to:	<201102182121.p1ILL1Fx029087@xxxxxxxxxxxxxxxxxxxxxx>
References:	<201102182121.p1ILL1Fx029087@xxxxxxxxxxxxxxxxxxxxxx>
User-agent:	Mutt/1.5.20 (2009-06-14)

On Fri, Feb 18, 2011 at 03:21:01PM -0600, Alex Elder wrote:
> Each of the last five characters in the obfuscated name are
> generated the same way.  Replace that repeated block of code
> with an equivalent loop.
> 
> Signed-off-by: Alex Elder <aelder@xxxxxxx>

Nice simplification.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v3, 06/16] xfsprogs: metadump: replace repeated blocks with a loop, Alex Elder Re: [PATCH v3, 06/16] xfsprogs: metadump: replace repeated blocks with a loop, Dave Chinner <=

Previous by Date:	Re: [PATCH v3, 05/16] xfsprogs: metadump: eliminate a pointless loop in generate_obfuscated_name(), Dave Chinner
Next by Date:	Re: [PATCH v3, 07/16] xfsprogs: metadump: use pointers in generate_obfuscated_name(), Dave Chinner
Previous by Thread:	[PATCH v3, 06/16] xfsprogs: metadump: replace repeated blocks with a loop, Alex Elder
Next by Thread:	[PATCH v3, 05/16] xfsprogs: metadump: eliminate a pointless loop in generate_obfuscated_name(), Alex Elder
Indexes:	[Date] [Thread] [Top] [All Lists]